jeux/le-grand-concours
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases 1 Packages 1 Wiki Activity Actions

fix(types): harden migration and test coverage (#10) #24

Merged
Reliodas merged 3 commits from refactor/10-migrate-to-typescript into develop 2026-06-22 20:07:31 +00:00
Conversation 0 Commits 3 Files changed 45 +5945 -1594
Reliodas commented 2026-06-22 20:04:28 +00:00
Owner
Copy link

Résumé

  • remplace les déclarations partagées permissives par des unions TypeScript discriminées et vérifiées
  • sépare les projections MJ, candidat et spectateur pour éviter les fuites de réponses
  • valide les charges utiles Socket.IO à l’exécution
  • ajoute Jest, Vitest Coverage et Playwright avec des seuils bloquants dans Woodpecker
  • rend le build client indépendant des assets privés ignorés
  • documente le cycle Forgejo et les pièges spécifiques pour Claude Code

Validation

  • shared : typecheck et build
  • serveur : typecheck, 72 tests node:test réussis, 1 ignoré, 4 tests Jest, couverture bloquante et build
  • client : typecheck, 33 tests Vitest, couverture bloquante, build sans publicDir et parcours Playwright multi-navigateur
  • Woodpecker #29 : test-shared, test-server, test-client et test-e2e réussis sur 2c0a6dc

Ticket

Complète les critères restants de #10. Le ticket sera fermé après fusion.

## Résumé - remplace les déclarations partagées permissives par des unions TypeScript discriminées et vérifiées - sépare les projections MJ, candidat et spectateur pour éviter les fuites de réponses - valide les charges utiles Socket.IO à l’exécution - ajoute Jest, Vitest Coverage et Playwright avec des seuils bloquants dans Woodpecker - rend le build client indépendant des assets privés ignorés - documente le cycle Forgejo et les pièges spécifiques pour Claude Code ## Validation - shared : typecheck et build - serveur : typecheck, 72 tests node:test réussis, 1 ignoré, 4 tests Jest, couverture bloquante et build - client : typecheck, 33 tests Vitest, couverture bloquante, build sans publicDir et parcours Playwright multi-navigateur - Woodpecker #29 : test-shared, test-server, test-client et test-e2e réussis sur 2c0a6dc ## Ticket Complète les critères restants de #10. Le ticket sera fermé après fusion.
fix(types): harden migration and test coverage
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details
f833d898a2 
Add role-safe discriminated contracts, runtime socket validation, Jest and Playwright suites, and blocking coverage checks in CI.

Refs #10
fix(client): resolve private assets at runtime
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
2c0a6dc194 
Keep ignored logo and background assets out of Vite module resolution so clean CI checkouts can build successfully.

Refs #10
docs(claude): document migration pitfalls
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details
df7f3cfd3b 
Warn about reused merged branches, ignored runtime assets, exact-commit CI verification, and coverage threshold regressions.

Refs #10
Reliodas merged commit 6b62306b69 into develop 2026-06-22 20:07:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jeux/le-grand-concours#24
No description provided.
Delete branch "refactor/10-migrate-to-typescript"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?